Repository navigation
fix(Hex): decode odd-length signed hex and reject unsized negative numbers - #584
Merged
Merged
Conversation
…mbers Hex.toBigInt and Hex.toNumber with signed: true computed a fractional byte width for odd-length hex and threw a RangeError. Hex.fromNumber with signed: true and no size let negative numbers through and encoded them as 0x0. Supersedes #439. Co-authored-by: gomesalexandre <contact@alexandregomes.fr> Amp-Thread-ID: https://ampcode.com/threads/T-01a1bc8f-2366-769e-b08c-408e9dab25b0 Co-authored-by: jxom <jake@tempo.xyz>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Published pnpm add ox@pr-584
pnpm add ox@0.0.0-pr-584-c5591b1 |
Merged
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #439 by @gomesalexandre (credited as co-author).
Fixes two signed-integer bugs in
Hex:Hex.toBigIntandHex.toNumberwithsigned: truethrew aRangeErroron odd-length hex (e.g.Hex.toBigInt(Hex.fromNumber(420), { signed: true })), because the byte width came out fractional. The width now comes fromHex.size, which rounds up, so odd-length hex is read as left-padded to whole bytes. That matchesBytes.fromHexand viem (fix: handle odd-length hex in signed hexToBigInt / hexToNumber viem#4913).Hex.fromNumber(-1, { signed: true })with nosizereturned0x0. It now throwsIntegerOutOfRangeError, the same as thebigintoverload already did. Passingsignedwithoutsizeis already a type error, so only untyped callers see the change.No other ox caller changes behavior: every internal caller that passes
signedalso passessizeor pads to whole bytes. The new assertions inHex.test.tsfail without the source change.